Skip to content

Conversation

@infiniteregrets
Copy link
Member

Summary

Add s2-lite to workspace dependencies so release-plz manages the version automatically. Required for crates.io publishing.

Test plan

  • cargo check -p s2-cli passes
  • cargo publish -p s2-cli --dry-run passes
  • Merge and re-trigger release

🤖 Generated with Claude Code

Add s2-lite to workspace dependencies so release-plz manages the
version automatically. Required for crates.io publishing.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@greptile-apps
Copy link

greptile-apps bot commented Jan 29, 2026

Greptile Overview

Greptile Summary

This PR adds s2-lite to the workspace dependencies, enabling release-plz to automatically manage its version during releases. This change is necessary for proper crates.io publishing of s2-cli.

Changes:

  • Added s2-lite = { version = "0.26.0", path = "lite" } to workspace dependencies in root Cargo.toml
  • Updated cli/Cargo.toml to reference s2-lite via workspace = true instead of direct path

Impact:

  • Ensures consistent versioning across workspace packages
  • Enables release-plz to update s2-lite version automatically
  • Maintains functional equivalence (both resolve to same path)
  • Required for successful cargo publish -p s2-cli

Confidence Score: 5/5

  • This PR is safe to merge - it's a straightforward dependency management improvement with no functional changes
  • The changes are minimal, well-tested (cargo check and dry-run passed), and follow Rust workspace best practices. The modification only affects dependency resolution metadata without altering any code logic. Both files resolve to the same package, ensuring no behavioral changes.
  • No files require special attention

Important Files Changed

Filename Overview
Cargo.toml Added s2-lite to workspace dependencies for release-plz version management
cli/Cargo.toml Updated s2-lite dependency to use workspace version instead of local path

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant CLI as s2-cli
    participant Lite as s2-lite
    participant WS as Workspace Dependencies
    participant RPZ as release-plz

    Note over Dev,RPZ: Before PR: s2-lite not in workspace deps
    Dev->>CLI: Uses s2-lite via path="../lite"
    CLI->>Lite: Direct path dependency
    Note over RPZ: release-plz doesn't manage s2-lite version

    Note over Dev,RPZ: After PR: s2-lite in workspace deps
    Dev->>WS: Adds s2-lite v0.26.0 to workspace
    Dev->>CLI: Changes to workspace = true
    CLI->>WS: Uses workspace dependency
    WS->>Lite: Resolves to path = "lite"
    RPZ->>WS: Manages s2-lite version automatically
    Note over RPZ: Enables proper versioning for crates.io
Loading

@infiniteregrets infiniteregrets merged commit 2623bf3 into main Jan 29, 2026
10 checks passed
@infiniteregrets infiniteregrets deleted the fix/cli-lite-workspace-dep branch January 29, 2026 03:34
@github-actions github-actions bot mentioned this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant